search

st900278 / Imgur-Uploader-Firefox

Addon for firefox to upload image to Imgur
Mozilla Public License 2.0
24 stars 8 forks source link

Withdrawn from AMO, why? #31

Open Guest126 opened 2 years ago

Guest126 commented 2 years ago

I noticed that Imgur-Uploader-Firefox has been removed from addons.mozilla.org (AMO).

https://addons.mozilla.org/firefox/addon/imgur-upload/

@st900278, why is this?

So I forked this and published it on AMO.

https://addons.mozilla.org/firefox/addon/imgur-uploader/

But this does not take over the images I uploaded anonymously in the past. (Maybe possible to edit the SQLite database directly?)

It is best that st900278 republish it on AMO. Is there anything I can do?

st900278 commented 2 years ago

Oh!, I totally forgot this work. In March, AMO does not accept pre-installed node_modules, and said that I need to provide the build instructions (just zipping the file is not enough) on how to generate the final xpi.

I would like to republish it. But I am very busy in this week, I would like to do it in the end of September. By the way, can you tell me how to provide the build instructions?

Guest126 commented 2 years ago

That’s what I thought.

In fact, Webpack 3.x builds a so-so readable js file, so I was able to successfully publish the add-on without providing source and build instructions.

That said, the latest Webpack (5.x) obfuscates the source. I will make a pull request later for future reference.

Guest126 commented 2 years ago

Thank you for your patience. My fork passed Mozilla's review. Please merge one of them as you like.

The list of files in the submitted source code archive (separately from xpi);

st900278 commented 2 years ago

Thank you so much for the work. After a busy month, I finally can start working on this. I would read the changes and merge them. After that, I would resubmit to AMO again. I hope this can be done in Oct.7.

st900278 commented 2 years ago

I have received AMO's result. They said that some of the code has security issues about inserting external contents. For example: src\settings\image_manage.js - line 130

For more information, see https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Safely_inserting_external_content_into_a_page

I will spend some time to fix these issues in these weeks (sigh).