search

stCarolas / setup-maven

Set up your GitHub Actions workflow with a specific version of Apache Maven
MIT License
57 stars 68 forks source link

Ensures the proper dynamically constructed Apache mirror download is … #9

Closed joewitt closed 3 years ago

joewitt commented 3 years ago

ASF infrastructure doesn't want downlaods direct from the archive. Instead you should use download mirrors. This is best done using a dynamically constructed mirror URL. This code change moves to this approach which will ensure we distribute download to appropriate global servers and doesn't get us blocked by ASF infra.

joewitt commented 3 years ago

@stCarolas Not sure if you're still active on this but we're trying to use this plugin for NiFi now as we're not quite ready for the latest maven version and want to explicitly set it in our builds. The setup-java folks have decided to not allow maven version to be configurable. As far as I can tell your action here is the best option as of now. The change I've suggested here should make this more safely useable by others.

If you're able in terms of time could you review and kick out a release? If not all good and thanks for the consideration.

stCarolas commented 3 years ago

released as v4.1