search

sta-c0000 / tpconf_bin_xml

Command line utility to convert TP-Link router backup config files
160 stars 40 forks source link

Support for Archer VR1600v #27

Closed mcoops closed 2 years ago

mcoops commented 2 years ago

Small update to support the Archer VR1600v, tested and works as expected with the change.

sta-c0000 commented 2 years ago

Hi, thank you for the PR! I’m a little surprised that regex produces false positives, but if it occurs with the VR1600v, it might occur with other models… I might prefer to narrow the regex over adding exclusions.

Does the XML HardwareVersion line for the VR1600v look something like this?:

      <HardwareVersion val="Archer VR1600v v2 00000000" />

I'm curious where in the conf.xml does it exactly match the regex “Archer C2[0-9]?[A-z]? v1” (“Archer C2[possible number][possible letter] v1”)? Can you post that specific line (or tree) from the xml file?

Thanks.

mcoops commented 2 years ago

Ha, you're absolutely correct, it shouldn't have any affect whatsoever. It must've just been an issue with the config and for some reason I thought that'd fix it, gah. Re-testing master it's fine.

Thanks for double checking!