sta / websocket-sharp

A C# implementation of the WebSocket protocol client and server
http://sta.github.io/websocket-sharp
MIT License
5.75k stars 1.66k forks source link

TLS1.2 error, docs can be improved #540

Open andreireiand opened 5 years ago

andreireiand commented 5 years ago

With current push to disable weak ciphers, the:

close 1015 An exception has occurred while connecting.

error is mostly everywhere. Hence, below procedure: private enum SslProtocolsHack { Tls = 192, Tls11 = 768, Tls12 = 3072 } var sslProtocolHack = (System.Security.Authentication.SslProtocols)(SslProtocolsHack.Tls12 | SslProtocolsHack.Tls11 | SslProtocolsHack.Tls);ws.SslConfiguration.EnabledSslProtocols = sslProtocolHack;

needs be added in default front page documentation, otherwise people might loose a full day just researching for the error code ...

or even better, make this setting the default behavior.

Crydsch commented 4 years ago

I'd like to bump on this Issue!

This March Browsers will drop TLS 1.0 and TLS1.1 support entirely. The current default behavior will break applications!

References: Mozilla Firefox Google Chrome

nelsontkq commented 3 years ago

Is this out of date? Doesn't the current behaviour set it to SslProtocols.None which allows the OS to handle TLS?