search

sta / websocket-sharp

A C# implementation of the WebSocket protocol client and server
http://sta.github.io/websocket-sharp
MIT License
5.68k stars 1.66k forks source link

support dotnet core 3.0 #569

Open sharkguto opened 4 years ago

sharkguto commented 4 years ago

is there any chance to implement it for dotnet core 3.0?

rentocika commented 4 years ago

@sharkguto I've simple add all files to new NET Core project and change TargetFramework to TargetFrameworks and write required target's. But in .NET Core I've issue with System.Net.Sockets.NetworkStream

rentocika commented 4 years ago

There is my errors: 11/20/2019 12:43:16|Fatal|<>cDisplayClass84_0.b0|Operation is not supported on this platform. 11/20/2019 12:43:16|Fatal|<>cDisplayClass174_0.b2|System.ObjectDisposedException: Cannot access a disposed object. Object name: 'System.Net.Sockets.NetworkStream'. at System.Net.Sockets.NetworkStream.EndRead(IAsyncResult asyncResult) at WebSocketSharp.Ext.<>cDisplayClass57_0.b0(IAsyncResult ar) in /websocket-sharp/websocket-sharp/Ext.cs:line 792 11/20/2019 12:48:11|Fatal|<>cDisplayClass174_0.b2|System.ObjectDisposedException: Cannot access a disposed object. Object name: 'System.Net.Sockets.NetworkStream'. at System.Net.Sockets.NetworkStream.EndRead(IAsyncResult asyncResult) at WebSocketSharp.Ext.<>cDisplayClass57_0.b0(IAsyncResult ar) in /websocket-sharp/websocket-sharp/Ext.cs:line 825 11/20/2019 12:52:11|Fatal|<>cDisplayClass174_0.b2|System.ObjectDisposedException: Cannot access a disposed object. Object name: 'System.Net.Sockets.NetworkStream'. at System.Net.Sockets.NetworkStream.EndRead(IAsyncResult asyncResult) at WebSocketSharp.Ext.<>c__DisplayClass57_0.b__0(IAsyncResult ar) in /websocket-sharp/websocket-sharp/Ext.cs:line 825

codefrx commented 4 years ago

same issue here with net core 3, it will be great if next release support net core 3

rogergoldfish commented 4 years ago

As the core 3.1 is available now, any plan to support it in the near future?

nixxholas commented 4 years ago

Currently working on an unofficial fork for .NET Core. @rogergoldfish @codefrx @ShaihutdinovRZ @sharkguto Need a little more time. https://github.com/nozomi-ai/websocket-sharp