re-validate test coverage

staabm / phpstan-dba

PHPStan based SQL static analysis and type inference for the database access layer

https://staabm.github.io/archive.html#phpstan-dba

MIT License

250 stars 17 forks source link

re-validate test coverage #371

Open staabm opened 2 years ago

staabm commented 2 years ago

it seems since introducing pdo-pgsql we missed a bit of testcoverage

rule tests seem to only exist for pdo-mysql and mysqli, but non for pgsql
double check test-cases which use $this->markTestSkipped(...) for certain cases, to make sure we don't miss feature coverage for one of the drivers (in which it might even work already, but just not covered by tests)

staabm commented 2 years ago

@p4veI @xPaw @marmichalski maybe thats something one of you guys are interessted in working on?

p4veI commented 2 years ago

I'll try to take a look

staabm commented 2 years ago

next step would be merging testsuites of Mysqli and PDO in case the same unit is tested, e.g. SyntaxErrorInQueryMethodSubclassedRuleMysqliReflectorTest and SyntaxErrorInQueryMethodSubclassedRulePdoReflectorTest

similar to what I did in https://github.com/staabm/phpstan-dba/pull/386/

same is true for all other rule tests, where we have a Pdo and Mysqli variant, but testing the very same Rule-class

I would prefer a new PR per unit beeing tested