Closed b-viguier closed 2 months ago
Just fixed the master
build with https://github.com/staabm/phpstan-dba/pull/652
please try again while making sure you are running the tests with doctrine/dbal:^3
like I did in above PR
Thanks @staabm ! Tests added đ I was confused by cache files, but as far as I understand they are expected to be updated, so I included them (not sure if all cache files are up to date)
Thank you!
Hi đ đ
I encountered an edge case with the Regex currently used to parse placeholders.
âšī¸
"
are needed here to escape the-
special character in the field's nameThe problem with the current
(["\'])([^"\']*\1)
regex is that it tries to exclude'
AND"
in the middle of a string. If this is a simply quoted string we should exclude only simple quotes.I found a way to negate a backreference in stackoverflow.
~Unfortunately, I totally failed to run tests locally, so I didn't add corresponding test... but I would love to if you have some helping instructions~ ~[Edit] it seems that locally I got the same errors encountered by the CI, so maybe the issue is not related to my local setup but to
master
branch...~ [Edit 2 ] tests added đThanks for you work đ