search

staabm / phpstan-todo-by

Todo comments with expiration
https://staabm.github.io/2023/12/17/phpstan-todo-by-published.html
MIT License
173 stars 4 forks source link

UX: better readable date format #5

Closed staabm closed 8 months ago

staabm commented 9 months ago

consider using a more human readable date format, e.g. with month as a written word

// TODO: 2023 December 14 Expired comment1

goal: make it clear which part of the date is the day and which is the month

the dateformat implemented initially is the one used by the projects which this extension got inspiration from. we might support both formats. we should stay compatible with the inspiring repos.

we need to check whether adding more formats has a perf impact

dereuromark commented 8 months ago

As clearly identifiable ISO date it is already clear which part is what IMO. Thats international standard for a reason, don't you agree?

More human syntax can only introduce more likely false-negative (typo to not be found by regex and thus not alerting when the time comes). E.g. German

// TODO: 2023 Dezember 14 ..

You think it will, but it will then never actually get triggered because the dev used German way of writing it.

staabm commented 8 months ago

There are so many date formats and depending on country / region expectations area different.

Sure its a standard, but people might be used to different formats and therefore mix it up.

I just had the idea, that we could validate the date format ranges to make it a bit more stable.

github-actions[bot] commented 7 months ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.