search

staabm / phpstan-todo-by

Todo comments with expiration
https://staabm.github.io/2023/12/17/phpstan-todo-by-published.html
MIT License
172 stars 4 forks source link

Improve Expiration Date recognition #53

Closed boxblinkracer closed 8 months ago

boxblinkracer commented 8 months ago

Hi

I was playing around with it, and figured out that the expiration date has to be in a strict format with 2-digit months

if people do not pay attention to that, then NO error is being displayed, which is risky

throws error - OK

// TODO: 2023-01-22 This comment turns into a PHPStan error as of 22nd december 2023

should throw error but does not - NOT OK

// TODO: 2023-1-22 This comment turns into a PHPStan error as of 22nd december 2023

maybe this could be improved :)

thanks for this great extension

boxblinkracer commented 8 months ago

yes. thanks for that super fast fix 🎉

github-actions[bot] commented 7 months ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.