search

staabm / phpstan-todo-by

Todo comments with expiration
https://staabm.github.io/2023/12/17/phpstan-todo-by-published.html
MIT License
172 stars 4 forks source link

Show readable error when ticket doesn't exist #61

Closed EmilMassey closed 8 months ago

EmilMassey commented 8 months ago

Currently, if the ticket doesn't exist, exception is thrown. This PR fixes this and now it's reported as normal error: Ticket APP-000 doesn't exist.

Please note that 404 is also returned by Jira if provided credentials do not allow for viewing the ticket even if it exists so it's not possible to distinguish these two reasons.

staabm commented 8 months ago

thanks for the PR.

Please note that 404 is also returned by Jira if provided credentials do not allow for viewing the ticket even if it exists so it's not possible to distinguish these two reasons.

we should reflect that in the error message.

staabm commented 8 months ago

thank you