search

staabm / phpstan-todo-by

Todo comments with expiration
https://staabm.github.io/2023/12/17/phpstan-todo-by-published.html
MIT License
172 stars 4 forks source link

DX: Define error identifiers #82

Closed EmilMassey closed 7 months ago

EmilMassey commented 7 months ago

In phpstan 1.11 error identifiers will be available for use to ignore specific errors. We can already use PHPStan\Rules\RuleErrorBuilder::identifier() to define custom identifiers for errors reported by this extension. They will be useful when 1.11 is released.

I think it would be a nice feature to have. If we want to have it, we should discuss what the identifiers should look like, eg. todo_by.date, todo_by.ticket, etc.

staabm commented 7 months ago

Agree :+1:

staabm commented 7 months ago

I think we can start with one error per rule. phpstan seems to use camel case for them.

staabm commented 7 months ago

implemented in https://github.com/staabm/phpstan-todo-by/pull/83

github-actions[bot] commented 5 months ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.