search

staabm / phpstan-todo-by

Todo comments with expiration
https://staabm.github.io/2023/12/17/phpstan-todo-by-published.html
MIT License
172 stars 4 forks source link

Fix bug when same GitHub issue is referenced in multiple ways #97

Closed EmilMassey closed 3 months ago

EmilMassey commented 3 months ago

Currently in case of GitHub there are multiple ways we can use to reference the same issue. This PR fixes runtime exception (Missing ticket-status for key #59) that was thrown in this situation.

staabm commented 3 months ago

Thanks

staabm commented 3 months ago

the new test failed on the main branch after merge: https://github.com/staabm/phpstan-todo-by/actions/runs/9227566752/job/25389786214

EmilMassey commented 3 months ago

the new test failed on the main branch after merge: https://github.com/staabm/phpstan-todo-by/actions/runs/9227566752/job/25389786214

The composer require step of failed pipeline used outdated git commit for some reason. Should have downloaded 27166f4561f54f1d14aac8651161d32184e38618 but fetched 774f707 instead. This is the previous version, that did not have the fix. See https://github.com/staabm/phpstan-todo-by/actions/runs/9227566752/job/25389786214#step:6:26

It seems the failure is related to the CI process rather than changes made in this PR. Maybe it’s some caching issue? Maybe in composer we should require concrete commit hash and not branch name? Unfortunately I’m not that familiar with GitHub actions so I don’t know what exactly went wrong here.

staabm commented 3 months ago

Thanks for checking. I just did a new commit and it is green now.