Enable CLI processing - Githubissues

staabm / xhprof.io

Maintained fork of xhprof.io: GUI to analyze the profiling data collected using XHProf – A Hierarchical Profiler for PHP.

Other

42 stars 10 forks source link

Enable CLI processing #34

Closed mdevine82 closed 9 years ago

mdevine82 commented 9 years ago

Right now CLI processing isn't enabled because the project is using some of the HTTP server globals to build up the data model. So here are some of my initial thoughts for replacements.

We do a check to see if its a CLI script and if so

Make 'method' = CRON
Make 'uri' = Fetch the script run name and possibly the args used and append them to a URI
Make 'host' = This one I could see going a few different ways. Either we could use the systems hostname or have some sort of set value from the config file maybe

staabm commented 9 years ago

As pointed out in https://github.com/gajus/xhprof.io/issues/63 a PR adding cli support is very welcome.

The host could be filled by the nodename provided by http://php.net/manual/en/function.posix-uname.php

staabm commented 9 years ago

fixed in https://github.com/staabm/xhprof.io/pull/35