stablekernel / aqueduct

Dart HTTP server framework for building REST APIs. Includes PostgreSQL ORM and OAuth2 provider.
https://aqueduct.io
BSD 2-Clause "Simplified" License
2.41k stars 280 forks source link

Deprecated lint rule warning in Aqueduct (minor) #643

Open chstrong opened 5 years ago

chstrong commented 5 years ago

OS: MacOS Mojave

Steps to replicate the warning: brew upgrade dart --> Results in Dart version 2.2 pub global activate aqueduct --> Results in Package aqueduct is currently active at version 3.2.0 aqueduct create my_project --> Results in (see Downloaded Packages title below)

Observation: "'super_goes_last' is a deprecated lint rule and should not be used" warning pops up which originates in analysis_options.yaml.

Issue might be due to older version of analyzer than available.

Workaround: When removing the "super_goes_last" from analysis_options.yaml the warning vanishes. Not sure for what this is used in Aqueduct, but thought I'll mention it.

Downloaded Packages -- Aqueduct CLI Version: 3.2.0 Template source is: /Users/chstrong/.pub-cache/hosted/pub.dartlang.org/aqueduct-3.2.0/templates/default/ See more templates with 'aqueduct create list-templates' -- Copying template files to new project directory (/Users/chstrong/Development/teach_api)... Copying contents of /Users/chstrong/.pub-cache/hosted/pub.dartlang.org/aqueduct-3.2.0/templates/default/test Copying contents of /Users/chstrong/.pub-cache/hosted/pub.dartlang.org/aqueduct-3.2.0/templates/default/bin Copying contents of /Users/chstrong/.pub-cache/hosted/pub.dartlang.org/aqueduct-3.2.0/templates/default/README.md Copying contents of /Users/chstrong/.pub-cache/hosted/pub.dartlang.org/aqueduct-3.2.0/templates/default/pubspec.yaml Copying contents of /Users/chstrong/.pub-cache/hosted/pub.dartlang.org/aqueduct-3.2.0/templates/default/.gitignore Copying contents of /Users/chstrong/.pub-cache/hosted/pub.dartlang.org/aqueduct-3.2.0/templates/default/lib Copying contents of /Users/chstrong/.pub-cache/hosted/pub.dartlang.org/aqueduct-3.2.0/templates/default/config.src.yaml Copying contents of /Users/chstrong/.pub-cache/hosted/pub.dartlang.org/aqueduct-3.2.0/templates/default/analysis_options.yaml Copying contents of /Users/chstrong/.pub-cache/hosted/pub.dartlang.org/aqueduct-3.2.0/templates/default/.travis.yml Generating config.yaml from config.src.yaml. -- Fetching project dependencies (pub get --no-packages-dir )... -- Please wait... The --packages-dir flag is no longer used and does nothing. Resolving dependencies...

mhelmetag commented 5 years ago

I believe this is fixed but just hasn't been release in the last version. At least this lint rule doesn't exist in the template files anymore.

For example, https://github.com/stablekernel/aqueduct/blob/master/aqueduct/templates/db_and_auth/analysis_options.yaml.

But basically, this should be closable on the next release.