stac-extensions / classification

Describes categorical values and bitfields to give values in a file a certain meaning (classification).
Apache License 2.0
11 stars 3 forks source link

Add name regex and title to class object #40

Closed gadomski closed 1 year ago

gadomski commented 2 years ago

Adds a name regex (^[0-9A-Za-z-_]+$) and an optional title field to the class object. This helps solidify what "machine readable" means for the name, and provides a way for a data provider to give a human-readable title for, e.g., map legends.

Related issues

drwelby commented 2 years ago

Thanks for adding this, should we consider this to be 1.2.0?

gadomski commented 2 years ago

Adding regex validation to name feels like a breaking change to me, so should would require v2?

drwelby commented 2 years ago

argh yes, coffee hasn't kicked in

m-mohr commented 1 year ago

How to continue with this one?

gadomski commented 1 year ago

How to continue with this one?

I think it's a good change (unsurprisingly, because I made it). We could merge it, but wait to accumulate some more breaking changes before releasing v2.0.0? I don't think anyone is clamoring for this one to be released immediately.

m-mohr commented 1 year ago

Looks good, but needs a CHANGELOG entry @gadomski

gadomski commented 1 year ago

Done.