Closed gadomski closed 1 year ago
Thanks for adding this, should we consider this to be 1.2.0?
Adding regex validation to name
feels like a breaking change to me, so should would require v2?
argh yes, coffee hasn't kicked in
How to continue with this one?
How to continue with this one?
I think it's a good change (unsurprisingly, because I made it). We could merge it, but wait to accumulate some more breaking changes before releasing v2.0.0? I don't think anyone is clamoring for this one to be released immediately.
Looks good, but needs a CHANGELOG entry @gadomski
Done.
Adds a name regex (
^[0-9A-Za-z-_]+$
) and an optionaltitle
field to the class object. This helps solidify what "machine readable" means for the name, and provides a way for a data provider to give a human-readable title for, e.g., map legends.Related issues