`name` in `label:classes` can be null

stac-extensions / label

Items that relate labeled AOIs with source imagery.

Apache License 2.0

9 stars 3 forks source link

`name` in `label:classes` can be null #8

Closed cuttlefish closed 3 years ago

cuttlefish commented 3 years ago

I'm unsure if this is correct or not, but it attempts to address #7

m-mohr commented 3 years ago

null is only allowed for raster, right? So I guess we should go one step further and only allow null if label:type is set to raster, right?

cuttlefish commented 3 years ago

I'm not very familiar with JSON Schema. Is this roughly how it would work? I haven't had a chance to test it yet. I guess we need a raster example for that.

cuttlefish commented 3 years ago

@jisantuc Thanks for the review! I was working on a test case for this, but think I won't have time to get to it in the next few days. I could open another PR next week if you like