search

stac-extensions / ml-model

An Item and Collection extension to describe machine learning (ML) models that operate on Earth observation data.
Apache License 2.0
37 stars 0 forks source link

List of operating systems #7

Open m-mohr opened 2 years ago

m-mohr commented 2 years ago

The OS list is taken from Python, but there are some things that we should think about:

  1. For example, in R the "OS.type" constant is only one of "UNIX" (which covers both mac and linux derivates) or "windows". How does that translate?
  2. In node it looks similar to Python: https://nodejs.org/api/process.html#process_process_platform but there are more values. Should we extent the list a bit?
  3. Julia also has a variation: https://docs.julialang.org/en/v1/manual/handling-operating-system-variation/ etc - A quick survey would be good to get to a better list of OS
  4. cygwin is a "strange" OS and a special case. How should other similar cases be handled? Thinking about WSL, Wine etc.
m-mohr commented 2 years ago

@duckontheweb (No offence, just curious....) Was it intentional that you released without discussing the open issue(s)?

duckontheweb commented 2 years ago

Sorry, @m-mohr! I was working quickly to get a published version out and forgot to address this prior to publishing. The JSON schema is actually not checking for an enum on this property, so any string value will validate correctly. I will put in a PR that changes the description in the README to be a strong recommendation to be in line with the schema and I will also do a survey of some standard value (as you suggested) so we can get some more feedback on those).

m-mohr commented 2 years ago

👍 Good that there's no enum restriction (yet) so that it won't be a breaking change.