search

stac-utils / pgstac

Schema, functions and a python library for storing and accessing STAC collections and items in PostgreSQL
MIT License
153 stars 39 forks source link

add tests for collections search links #310

Closed vincentsarago closed 1 month ago

vincentsarago commented 1 month ago

while working on https://github.com/stac-utils/stac-fastapi-pgstac/pull/155 we encountered some strange behaviour with the next/prev links returned by pgstac

The first commit of this PR adds tests showing what I was expecting from pgstac

cc @bitner

Note: in tipg this is how we determine next/prev links https://github.com/developmentseed/tipg/blob/ea1ef949873abb7886811dce85a47913f38e3e38/tipg/collections.py#L783-L788

vincentsarago commented 1 month ago

🤔 well tests pass!

vincentsarago commented 1 month ago

@bitner I'm not sure to understand how the CI is design, thus I'm not sure that pgtap was ran with my last commit

bitner commented 1 month ago

Yeah, it doesn't look like tests ran at all.

drnextgis commented 1 month ago

In 'Files changed' tab I see changes that were already merged to the main branch before, like this https://github.com/stac-utils/pgstac/commit/b73d5703e4b179cdaad185d6795b66efa3bc7087.

drnextgis commented 1 month ago

Ah that makes sense because it was never included in the migrations.