stac-utils / pystac-client

Python client for searching STAC APIs
https://pystac-client.readthedocs.io
Other
154 stars 47 forks source link

Fields extension uses incorrect plural `includes` and `excludes` #689

Closed kurtmckee closed 3 months ago

kurtmckee commented 3 months ago

While interacting with a STAC API using pystac-client I found that pystac-client is submitting "include" and "exclude" fields with plural keys. This doesn't match the Fields extension documentation, and didn't work against the STAC API I was interacting with:

From the Fields extension documentation's Overview:

The fields object contains two attributes with string array values, include and exclude.

kurtmckee commented 3 months ago

@gadomski Thank you for the quick review and merge! Do you anticipate that this could be released as an 0.8.1 or 0.9.0 release, or are there additional changes in the pipeline that you'd like to wait for?

gadomski commented 3 months ago

Should be ok as a v0.8.1, and I can try to get that out today 👍🏼

kurtmckee commented 3 months ago

Hooray! Thank you!

gadomski commented 3 months ago

https://github.com/stac-utils/pystac-client/releases/tag/v0.8.1

kurtmckee commented 3 months ago

Thank you so much! :heart: