search

stac-utils / stac-check

Linting and validation tool for STAC assets
MIT License
17 stars 6 forks source link

Relax pin on stac-validator? #88

Closed TomAugspurger closed 1 year ago

TomAugspurger commented 2 years ago

In https://github.com/stac-utils/stac-check/blob/71e7f1d167fe780923ef2a934f16b99598da6d70/setup.py#L22, this is pinned directly to stac-validator==3.2.0. This makes it hard to use stac-check in environments that want / need a different version of stac-validator.

Does that need to be pinned tightly, or can that be left to the user?

jonhealy1 commented 2 years ago

Hi @TomAugspurger. Does stac-validator>=3.1.0 work? Theoretically I know what you are saying but I am not sure why anyone would want to use even older versions of stac-validator than 3.1.0? 3.1.0 will work with the new version of stac-check.

TomAugspurger commented 2 years ago

Thanks @jonhealy1! Generally speaking, the best practice is to pin to the lowest version of your dependency known to work with your package, as long as the additional maintenance cost isn't too high. >=3.1.0 should work just fine.