stac-utils / stac-fastapi-elasticsearch-opensearch

Elasticsearch backend for stac-fastapi with Opensearch support.
https://stac-utils.github.io/stac-fastapi-elasticsearch-opensearch
MIT License
24 stars 14 forks source link

Update for stac-fastapi v3.0.0a release #234

Closed jonhealy1 closed 1 month ago

jonhealy1 commented 2 months ago

Related Issue(s):

Description:

Update stac-fastapi parent libraries to v3.0.0a. There are quite a few changes made in this pr.

PR Checklist:

jonhealy1 commented 2 months ago

All of the filters tests/ functionality is broken

jonhealy1 commented 1 month ago

This is working now with stac-fastapi v3.0.0a #238

jonhealy1 commented 1 month ago

Some tests are passing locally in docker but failing here

jonhealy1 commented 1 month ago

I have no idea why this started failing after I merged the new changes from main - I will have to figure it our tomorrow ...

jonhealy1 commented 1 month ago

just this I guess in execute_search max_result_window = stac_fastapi.types.search.Limit.le something changed

pedro-cf commented 1 month ago

Can add this issue as related issue:

jonhealy1 commented 1 month ago

@pedro-cf Will this fix that issue?

pedro-cf commented 1 month ago

@pedro-cf Will this fix that issue?

yes like I meantioned in the issue:

Additional context

https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/blob/c5c96c91d576edd7de3187c17b4edc5ec62e85cb/stac_fastapi/core/stac_fastapi/core/core.py#L606

Issue seems to be the version of stac_pydantic==2.0.*, I believe this will be fixed if upgraded to stac_pydantic==3.0.0 with stac-fastapi.api==3.0.0

jonhealy1 commented 1 month ago

Maybe we should write a test for this? Would you like to be a maintainer of this repo? I sent you an invite just in case.

pedro-cf commented 1 month ago

@jonhealy1 added test_item_custom_links

jonhealy1 commented 1 month ago

linting error

jonhealy1 commented 1 month ago

test looks great

jonhealy1 commented 1 month ago

@pedro-cf extra inputs are not permitted in Item - something may need to change in stac-pydantic?

pedro-cf commented 1 month ago

@pedro-cf extra inputs are not permitted in Item - something may need to change in stac-pydantic?

yes that can be changed: https://docs.pydantic.dev/2.7/api/config/#pydantic.config.ConfigDict.extra

but should it ?

Not sure how to proceeed here, maybe this should not be allowed? kinda loses the point of this plugin though: https://github.com/stac-extensions/web-map-links

pedro-cf commented 1 month ago

perhaps it's best to revert this test

jonhealy1 commented 1 month ago

Let's revert the test for now and talk about this in #247. I think this is an issue with stac-pydantic according to this - https://schemas.stacspec.org/v1.0.0/item-spec/json-schema/item.json - it should work