move client.get_search to the baseclass

stac-utils / stac-fastapi

STAC API implementation with FastAPI.

https://stac-utils.github.io/stac-fastapi/

MIT License

225 stars 99 forks source link

move client.get_search to the baseclass #107

Open vincentsarago opened 3 years ago

vincentsarago commented 3 years ago

https://github.com/stac-utils/arturo-stac-api/blob/d46da52b484a3bdb802c169c9c4f68a4bfbe0997/stac_api/clients/postgres/core.py#L192-L260

This code is not linked to any DB call ;-)

jonhealy1 commented 2 months ago

This issue can be closed because it relates to code that was removed from the repository I think.

jonhealy1 commented 2 months ago

Or would we still want this code in the baseclass?

jonhealy1 commented 2 months ago

We created a api core library in stac-fastapi-elasticsearch-opensearch to try to separate database logic - https://github.com/stac-utils/stac-fastapi-elasticsearch-opensearch/tree/main/stac_fastapi/core. It's similar. I have wondered about moving the logic back into this project. The various backends all share a fair amount of logic. The sqlalchemy backend for instance could be re-built on the stac-fastapi-elasticsearch core library and it could help to make it more maintainable.