search

stac-utils / stac-fastapi

STAC API implementation with FastAPI.
https://stac-utils.github.io/stac-fastapi/
MIT License
226 stars 99 forks source link

Aggregation Extension #684

Closed jamesfisher-gis closed 4 weeks ago

jamesfisher-gis commented 2 months ago

Related Issue(s):

Description:

Adds base support for the STAC API Aggregation Extension

PR Checklist:

drnextgis commented 2 months ago

That's great to see movement in that direction! I have some questions/comments.

  1. AggregationExtensionPostRequest is defined but not used.
  2. Is it meant to be used with the filter extension or solely with the search API?
  3. Are there any changes that need to be made in stac-fastapi-pgstac or in pgstac to make it compatible with that backend?

Thanks in advance.

jamesfisher-gis commented 2 months ago

Thank you for the comments @drnextgis

  1. AggregationExtensionPostRequest is defined but not used.

Ah, yes. The aggregation extension spec defines the methods for /aggregate and /aggregation should be get or post. I will add post to the available methods.

  1. Is it meant to be used with the filter extension or solely with the search API?

The aggregation extension spec as-is relies only on the core item-search afaik. However, the one implementation in stac-server includes cql2 query parameter, meaning it relies on the Filter extension. @philvarner may have an opinion on if that is something specific to the implementation, or if there are updates needed in the Aggregation extension spec.

  1. Are there any changes that need to be made in stac-fastapi-pgstac or in pgstac to make it compatible with that backend?

I am working on an implementation for elasticsearch and opensearch. I am not sure how an implementation would be handled in pgstac.

jamesfisher-gis commented 1 month ago

Hey @philvarner let me know what you think of the changes to this PR. I think it is close to being complete.

jonhealy1 commented 1 month ago

Need to resolve conflicts too

jonhealy1 commented 1 month ago

Let's get @vincentsarago thoughts on this

jonhealy1 commented 1 month ago

Linting

jamesfisher-gis commented 1 month ago

Linting

@jonhealy1 Sorry, fixed

jonhealy1 commented 4 weeks ago

@vincentsarago Hi Vincent. How does this look now?

vincentsarago commented 4 weeks ago

Great work @jamesfisher-gis