move validate from classmethod to instance method

stac-utils / stac-task

Provides a class interface for running custom algorithms on STAC ItemCollections

Apache License 2.0

21 stars 5 forks source link

Closed ircwaves closed 2 months ago

ircwaves commented 2 months ago

Related Issue(s):

Proposed Changes:

push self._payload assignment up,
move self.validate(payload) -> self.validate(), with the latter inspecting the self._payload member.

PR Checklist:

[X] I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

ircwaves commented 2 months ago

@philvarner and or @gadomski -- think this is warrants a ⚠️ Breaking Change in the log?

pjhartzell commented 2 months ago

@philvarner and or @gadomski -- think this is warrants a ⚠️ Breaking Change in the log?

I think so. It breaks existing packages that rely on stac-task.

gadomski commented 2 months ago

Yup, 👍🏼 to marking as breaking.