stac-utils / stac4s

a scala library with primitives to build applications using the SpatioTemporal Asset Catalogs specification
Apache License 2.0
16 stars 10 forks source link

Migrate Franklin types to api module #119

Open jisantuc opened 4 years ago

jisantuc commented 4 years ago

Improvement

We have a number of types in Franklin that would be useful for things outside of the Franklin monolith. For instance, the types of query parameters are maintained in Franklin, but are also maintained (and sometimes out of sync) in projects that would like to communicate with Franklin instances. We should instead move types upstream to an api-client (or similar) package that both Franklin and Franklin consumers can depend on. That should live either here or in Franklin. An argument could be made that it should live here because "Franklin" doesn't have the same obvious STAC branding that stac4s has. An argument could be made that it belongs in Franklin because that's where its default consumer lives.

pomadchin commented 4 years ago

GeoTrellis server has also its own version of SearchFilters which is just a copy of what franklin has and it already caused troubles (incorrect temporal extent json representation for stac api queries, since static stac and stac api represent it in a different format): https://github.com/geotrellis/geotrellis-server/blob/develop/stac-example/src/main/scala/geotrellis/stac/api/SearchFilters.scala