search

stac-utils / titiler-pgstac

TiTiler + PgSTAC
https://stac-utils.github.io/titiler-pgstac/
MIT License
80 stars 29 forks source link

Feature/add point endpoint #150

Closed vincentsarago closed 10 months ago

vincentsarago commented 10 months ago

continues #146

The mai change is that I'm introducing multi_points_pgstac which replace rio-tiler's multi_values method (because we use item dict instead of url, so it's not hashable as dict key).

In multi_points_pgstac I'm constructing an Item ID using the id and collection which we says are mandatory (this is not asserted but should)

@hrodmn could you have a look and tell me your tough

vincentsarago commented 10 months ago

@hrodmn I'm having second though on the endpoint path /{lon},{lat}/values

I know we already have /{lon},{lat}/assets which might be the reason for the choice but at the same time in titiler (single item) we use /point/{lon},{lat}

would you be ok if we change this to /point/{lon},{lat} ?

hrodmn commented 10 months ago

@hrodmn I'm having second though on the endpoint path /{lon},{lat}/values

I know we already have /{lon},{lat}/assets which might be the reason for the choice but at the same time in titiler (single item) we use /point/{lon},{lat}

would you be ok if we change this to /point/{lon},{lat} ?

That's fine with me. When I started working on it I went with /point/{lon},{lat} but changed my mind after finding /{lon},{lat}/assets. I think it makes sense to stay consistent with titiler.