search

stachenov / quazip

Qt/C++ wrapper over minizip
Other
580 stars 233 forks source link

fix deprecated QDateTime warning ctor with Qt 6.8 #210

Closed pradlol closed 1 month ago

pradlol commented 1 month ago

this change fix compilation warnings with Qt version 6.8

issue: #207

cen1 commented 1 month ago

Please also replace what @sergeyy32 commented on, plus, there are a few usages in qztest that still emit a warning.

Also, consider QTimeZone::utc()

Otherwise lgtm.

pradlol commented 1 month ago

@cen1, @sergeyy32, thanks for review. fixed your comments.

there is another small question indirectly related to this PR: the readme mentions Qt4, is it still supported? just as far as I can see, Qt4 doesn't have QTimeZone class, and the test code in the develop branch uses it.

cen1 commented 1 month ago

Looking good.

Qt4 is most likely broken at this point in time.

  1. Nobody uses and tests it
  2. Github action that installs Qt only supports 5 and 6 so pipeline is not checking if Qt4 builds and passes tests.
  3. I'm not even sure if it's installable on current distros or if it would build from source.
  4. Constantly adding more compat just to keep Qt4 alive seems counterproductive and will just make the code worse.

Considering all active projects are transitioning from Qt5 to Qt6 and there is only legacy software using Qt4 (which can simply use an old quazip release) the most likely result will be that Qt4 will be removed as supported version in the future.