search

stachenov / quazip

Qt/C++ wrapper over minizip
Other
580 stars 233 forks source link

JlCompress UTF-8 support #211

Open cen1 opened 1 month ago

cen1 commented 1 month ago

Initial attempt to address #114

Two issues to resolve

  1. zip.setUtf8Enabled needs to be called before QuaZip::open to have any effect. Some JlCompress methods have QuaZip* zip as an input so passing a different Option there makes no difference. It could confuse someone who would expect this to be set either way, not the best API..

  2. Current integration tests do not really seem to test UTF-8 support (at least on Linux). Whether UTF-8 is enabled or not, the tests pass (see for example TestQuaZipFile::zipUnzip(), changing the flag makes no difference). Need to investigate why that is and test for negative example.

cen1 commented 1 month ago

Nevermind, number 2 is obvious. If UTF8 is not explicitely set, it will use platform? QTextCodec which on Linux is UTF8 so there is obviously no difference. I suspect the fact that most of the tests pass across platforms simply means that default codecs can handle UTF8 so it really does not matter.

To get a negative test we need to explicitely set a codec that won't be able to handle the filename.

I think we also need some cross OS tests where we zip on each platform and unzip on others. That is 6 tests per combo so need to be careful not to explode the matrix but probably worth doing at least the basic combinations (text codec, encryption, levels).