stack-auth / stack

Open-source Clerk/Auth0 alternative
https://stack-auth.com
Other
611 stars 89 forks source link

Fix #103 No Open Graph Meta Tags Present #113

Closed Riteshyadavanshi closed 3 days ago

vercel[bot] commented 4 days ago

@Riteshyadavanshi is attempting to deploy a commit to the Stack Team on Vercel.

A member of the Team first needs to authorize it.

CLAassistant commented 4 days ago

CLA assistant check
All committers have signed the CLA.

imran1khan commented 4 days ago

@Riteshyadavanshi bro, where is that issue, can you please show me, like a screen short etc

Riteshyadavanshi commented 4 days ago

Hey sir ,I have made the changes just now. you can check it

On Mon, Jul 1, 2024, 10:24 AM Zai Shi @.***> wrote:

@.**** commented on this pull request.

In apps/dashboard/src/app/layout.tsx https://github.com/stack-auth/stack/pull/113#discussion_r1660452194:

@@ -18,11 +18,15 @@ import { RouterProvider } from '@/components/router'; import { CSPostHogProvider, UserIdentity } from './providers';

export const metadata: Metadata = {

The base url should use the DASHBOARD_BASE_URL env var

In apps/dashboard/src/app/layout.tsx https://github.com/stack-auth/stack/pull/113#discussion_r1660452579:

title: { default: 'Stack Auth Dashboard', template: '%s | Stack Auth', }, description: 'Stack Auth is the fastest way to add authentication to your web app.',

  • openGraph:{

same here

In apps/dashboard/src/app/layout.tsx https://github.com/stack-auth/stack/pull/113#discussion_r1660452511:

@@ -18,11 +18,15 @@ import { RouterProvider } from '@/components/router'; import { CSPostHogProvider, UserIdentity } from './providers';

export const metadata: Metadata = {

also please make sure the formatting is aligned with the other part of the project

— Reply to this email directly, view it on GitHub https://github.com/stack-auth/stack/pull/113#pullrequestreview-2150397126, or unsubscribe https://github.com/notifications/unsubscribe-auth/A444J5FVE65EALXJSFZPN3TZKDOJRAVCNFSM6AAAAABKECUQF6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNJQGM4TOMJSGY . You are receiving this because you were mentioned.Message ID: @.***>

fomalhautb commented 3 days ago

Please do not open new PRs multiple times. Just update the PR.