stack-auth / stack

Open-source Auth0/Clerk alternative
https://stack-auth.com
Other
4.14k stars 263 forks source link

[GoodToHave] Term and Privacy page links in the signup page #192

Closed deepshaswat closed 2 months ago

bikaxh01 commented 3 months ago

I would love to work on this issue. Please assign it to me if possible.

N2D4 commented 3 months ago

You want to be able to supply your own terms and privacy page, and pass it into the Stack App config so it would be shown on the sign-in components?

@fomalhautb I believe you worked on something like this?

bikaxh01 commented 3 months ago

Here is a design I have attached for your review so that I can proceed correctly Design : https://github.com/user-attachments/assets/6ab4279f-b854-4968-b1ab-0c9333071995

N2D4 commented 2 months ago

Here is a design I have attached for your review so that I can proceed

Looks good in itself, but how would this work with OAuth providers? Will the checkbox also be required to click the "sign in with OAuth" button?

singhsag commented 2 months ago

We can have a disclaimer of terms and conditions and any other policy at the bottom and that will be applicable to both the ways of signup, there is no need to explicitly ask user to check the terms and condition. This method is used on most modern websites nowadays. Please see the below design. I can quickly make the changes if the design looks fine, please assign this to me.

image

singhsag commented 2 months ago

I made some initial changes, it will look like below

Screenshot 2024-08-29 at 12 56 15 PM
fomalhautb commented 2 months ago

https://github.com/stack-auth/stack/pull/227 Added here