search

stack-of-tasks / eigenpy

Efficient bindings between Numpy and Eigen using Boost.Python
BSD 2-Clause "Simplified" License
179 stars 39 forks source link

Failing to detect scipy even being installed #469

Closed miquelmassot closed 6 months ago

miquelmassot commented 6 months ago

Part of a CI pipeline, I am installing numpy and scipy, then EigenPy. The pipeline fails at finding scipy just after having installed it.

https://github.com/miquelmassot/g2o-python/actions/runs/9020024667/job/24784257118#step:4:160

nim65s commented 6 months ago

Hi @miquelmassot,

I'm currently working on this. Can you try https://github.com/cmake-wheel/eigenpy/commit/11897d25a9d66ec082d63075b689b91cd449e29d on your side ?

nim65s commented 6 months ago

Hum, no, you are not explicitly trying to build eigenpy, so you should use binaries. So I guess the best option is to wait a bit for me to release a package with the fix, sorry for that.

miquelmassot commented 6 months ago

Thanks for looking into this @nim65s ! Just to clarify:

nim65s commented 6 months ago

Wheels are not available for EigenPy, just source tarballs.

Could you elaborate on that ? I see plenty of wheels at https://pypi.org/project/eigenpy/#files

pip install numpy scipy && pip install EigenPy fails in the above CI pipeline.

This is expected. The first command change nothing for the second, as by default, pip builds stuff in isolated mode. It basically create a venv for the build, and install build dependencies there, no matter what you have on your computer. Therefore, the fix is to add scipy in the build dependency list on the package itself, which is what https://github.com/cmake-wheel/eigenpy/commit/11897d25a9d66ec082d63075b689b91cd449e29d is doing.

miquelmassot commented 6 months ago

I was wrong - I've edited my comment above. For the 2nd point - I will wait for a release with that fix, thanks!

nim65s commented 6 months ago

Oh, thanks. macos arm64 wheels build failed, and once again I didn't notice. Thanks a lot for the details !

https://cirrus-ci.com/task/5781938814844928?logs=install_cibuildwheel#L1 I'll fix this, it should be pretty fast.

nim65s commented 6 months ago

@miquelmassot : macosx_11_0_arm64 wheels are now available on https://pypi.org/project/eigenpy/#files. Could you check if this fix your CI, and close this thread accordingly ?

miquelmassot commented 6 months ago

Brilliant! thanks @nim65s