Add arm64 macOS wheels to releases

stack-of-tasks / pinocchio

A fast and flexible implementation of Rigid Body Dynamics algorithms and their analytical derivatives

http://stack-of-tasks.github.io/pinocchio/

BSD 2-Clause "Simplified" License

1.7k stars 366 forks source link

Closed devbanu closed 4 months ago

devbanu commented 4 months ago

Currently installing Pinocchio via pip on arm64 macOS, i.e. on modern Macs, takes a significant amount of time 10-20minutes depending on platform.

This problems is easily solved by enabling the creation of arm64 wheels in the release workflow.

I have created a PR that solves this problem here: https://github.com/cmake-wheel/pinocchio/pull/8

Note that the PR is under cmake-wheel/pinocchio because it contains the release.yml file which is not available in stack-of-tasks/pinocchio.

I am creating this issue as a way to inform you about this.

jcarpent commented 4 months ago

Sounds perfect to us! Very nice initiative @devbanu. Thanks a lot for your helpful contribution

nim65s commented 4 months ago

Hi,

arm64 macos wheel builds are fixed, and have been uploaded to PyPI for CPython 3.9, 3.10, 3.11 & 3.12 + PyPy 3.8.

PyPy 3.9 has an unknown error, and PyPy 3.10 segfaults, I'll investigate later about those.

Once again, thanks for the report, @devbanu !

cmastalli commented 4 months ago

Hi @nim65s and @devbanu

Thanks for your contribution. Would you be willing to do the same for Crocoddyl? Your support would be much appreciated by many users :)

devbanu commented 4 months ago

I will let @nim65s confirm, as he is more informed.

But it seems to me Crocoddyl's latest release (2.0.2 from Dec 7) already does provide arm64 macOS wheels.