search

stack-tools-js / stack-tools

Utilites for printing and parsing errors and their stacks
5 stars 1 forks source link

Audit internal frame logic #5

Open conartist6 opened 3 years ago

conartist6 commented 3 years ago

I have isInternalFrame functions which work, but I have not yet updated them with a comprehensive definition of what is an internal frame. I'm not sure how far I should go: both jest and ava have defined additional hacks to expand the definition of what was an internal frame over the base definition of what in internal frame is included in the version of stack-utils that they use currently.

I also need to consider whether changes to the definition of an internal frame would be considered breaking or non-breaking. Really the difference is probably in how I document what is supported. I would really like to reserve the right to tweak the definition as time goes on.

conartist6 commented 3 years ago

Ava's criteria for internal frames are here.

conartist6 commented 3 years ago

Jest's additional criteria for internal frames are here.