search

stack72 / TeamCitySharp

No Longer Maintained - please use https://github.com/mavezeau/TeamCitySharp
Other
200 stars 165 forks source link

Why should I specify login/password for guest access? #49

Closed jonnyzzz closed 11 years ago

jonnyzzz commented 11 years ago

I found the only one method Connect that requires me to specify login and password even if I about to use guestAuth.

I'd say it's better to have dedicated method like Connect() or ConnectAsGuest() for that

stack72 commented 11 years ago

I have just pushed this to a branch. the changes are here:

https://github.com/stack72/TeamCitySharp/blob/guest-connection/src/TeamCitySharp/Connection/IClientConnection.cs

I am presuming this is what you mean?

jonnyzzz commented 11 years ago

Exactly! Thanks!

stack72 commented 11 years ago

No worries - will merge this tonight and then publish it

Thanks for the feedback On 19 Oct 2013 19:24, "Eugene Petrenko" notifications@github.com wrote:

Exactly! Thanks!

— Reply to this email directly or view it on GitHubhttps://github.com/stack72/TeamCitySharp/issues/49#issuecomment-26655757 .

stack72 commented 11 years ago

Implemented in https://github.com/stack72/TeamCitySharp/pull/55