Closed Maleware closed 2 weeks ago
Tests green: 🟢
--- PASS: kuttl (206.16s)
--- PASS: kuttl/harness (0.00s)
--- PASS: kuttl/harness/smoke_airflow-2.9.2_openshift-false_executor-celery (206.12s)
PASS
The decision is not public, can you summarize what this is about and if it is something that is documented please include a link to the docs. If it's not documented can you briefly summarize why note?
Does this need to be mentioned in the release notes?
This is to allow the user to add arbitrary python code to the webserver_config.py
.
We've got it documented in our superset docs and airflow docs
However, this can be used for any case where superset allows us to replace functions with custom ones. It was driven by superset documentation about custom OIDC manager and we found that we should add it to airflow too.
We've reached a decision on that this is how airflow wants to be configured ( no matter how ugly it might appear ) and thus we want the operator to be useful in this case.
We've had an customer for airflow who wrote their whole config for themself ( basically ignoring the operators work and thus it's not used ) to achieve having own classes and functions. They now can use the configs the operator provides and have their custom code as a config.
I can't really make a objective statement weather or not we should mention it in the release notes. For me it should as it enables some customers and they might wanna know.
Left to do: Do we want to add python libraries to the Airflow Dockerfile
to have OIDC supported properly, if a customer chooses to do so?
Thank you. In that case: Can you please add a short sentence as it could appear in the release notes as a comment here?
Description
This PR is the outcome of the decision https://github.com/stackabletech/decisions/issues/21
Contains:
Definition of Done Checklist