stackabletech / airflow-operator

Stackable Operator for Apache Airflow
Other
22 stars 2 forks source link

feat: Support non-default cluster domain #518

Closed sbernauer closed 1 week ago

sbernauer commented 2 weeks ago

Description

Part of https://github.com/stackabletech/issues/issues/652

Definition of Done Checklist

# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated
sbernauer commented 2 weeks ago

Nice comments :D I intentionally did not add a changelog, as we only bumped op-rs, which we don't track there. And the airflow-op actually never uses the cluster domain, so it feels wrong to state that it now reads it "correctly" or whatnot, but no strong opinion. Is yours stronger? :)

maltesander commented 2 weeks ago

Nice comments :D I intentionally did not add a changelog, as we only bumped op-rs, which we don't track there. And the airflow-op actually never uses the cluster domain, so it feels wrong to state that it now reads it "correctly" or whatnot, but no strong opinion. Is yours stronger? :)

No fine with me.