stackabletech / docker-images

Apache License 2.0
15 stars 2 forks source link

Patch NiFi assembly to not zip binaries to save disk space #685

Closed maltesander closed 2 months ago

maltesander commented 2 months ago

Description

For NiFi version 1.21.0 and 1.23.2 the github runners do not have enough space and fail to build these images:

Error: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-install-plugin:3.1.0:install (default-install) on project nifi-toolkit-assembly: Failed to install artifact org.apache.nifi:nifi-toolkit-assembly:zip:bin:1.21.0: No space left on device -> [Help 1]

The nifi-assembly zips the resulting binaries which adds another ~1.3 GB but are not used in the main image since the unzipped binaries are copied over.

This PR patches the pom file to not zip the binaries in the end to save disk space.

Definition of Done Checklist

- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image The image can be built and uploaded to the kind cluster with the following commands: ```shell bake --product --image-version kind load docker-image --name= ``` See the output of `bake` to retrieve the image tag for ``.