stackabletech / docker-images

Apache License 2.0
15 stars 2 forks source link

feat: Add config-utils to stackable-base #706

Closed sbernauer closed 1 month ago

sbernauer commented 1 month ago

Description

We use cargo cyclonedx to place the SBOM alongside the binary, similar to what we do with the operators

Definition of Done Checklist

- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image The image can be built and uploaded to the kind cluster with the following commands: ```shell bake --product --image-version kind load docker-image --name= ``` See the output of `bake` to retrieve the image tag for ``.
lfrancke commented 1 month ago

Please wait with merging this. I don't have time to review this today but have some concerns and want to spend time to look at it in more depth either later today or tomorrow.

lfrancke commented 1 month ago

I'll tell you what I do not like about this but I can't think of a better solution right now: More hardcoded version numbers (rust toolchain, cyclonedx, auditable) and a duplication of the other builder it'd be great if the base image could really be the base but as I said: I don't have a better idea right now.