stackabletech / docker-images

Apache License 2.0
17 stars 2 forks source link

ci(pull-request): Enable pre-commit action #769

Closed NickLarsenNZ closed 2 months ago

NickLarsenNZ commented 2 months ago

Description

Enable pre-commit checks on pull requests.

[!NOTE] To avoid workflow failures, install pre-commit locally, and run pre-commit install.

[!IMPORTANT] nix-users: install ruff before running pre-commit, otherwise it will download an incorrectly linked version.

Definition of Done Checklist

- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image The image can be built and uploaded to the kind cluster with the following commands: ```shell bake --product --image-version kind load docker-image --name= ``` See the output of `bake` to retrieve the image tag for ``.