stackabletech / druid-operator

An Operator for Apache Druid for Stackable Data Platform
Other
10 stars 0 forks source link

fix: Correctly encode user given content, such as passwords #571

Closed fhennig closed 4 months ago

fhennig commented 5 months ago

Description

fixes #219

Integration tests were successful: https://ci.stackable.tech/view/06%20Replicated/job/druid-operator-it-replicated/8/console

Definition of Done Checklist

# Author
- [x] Changes are OpenShift compatible
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated
fhennig commented 5 months ago

running a test :crossed_fingers:

sbernauer commented 5 months ago

Just a meta comment: product-utils is coming to an release soon-ish. I think it would make sense to use that tool everywhere for consistency reasons [and not rely on Druid features that might do thing slightly differently].

fhennig commented 4 months ago

You might be right there. I can also see an argument for using less parts, but maybe the consistency is better to have here. Happy to have other opinions, maybe @soenkeliebau