search

stackabletech / druid-operator

An Operator for Apache Druid for Stackable Data Platform
Other
10 stars 0 forks source link

test(kuttl): Remove the -o pipefail bash option #619

Closed NickLarsenNZ closed 2 months ago

NickLarsenNZ commented 2 months ago

Kuttl hard codes sh -c, instead of allowing alternative shells to be used. For now, we need to drop the -o pipefail option.

I think https://github.com/kudobuilder/kuttl/issues/50 was incorrectly closed, as the issue author asked for "bash script".

[!NOTE] For Macos and NixOs users, sh appears to work like bash, so locally set -euo pipfail worked fine.

NickLarsenNZ commented 2 months ago

I have raised https://github.com/kudobuilder/kuttl/issues/557

NickLarsenNZ commented 2 months ago

LGTM, Assume you've tested

I have run one of the overlay tests and it passes:

=== NAME  kuttl
    harness.go:408: run tests finished
    harness.go:516: cleaning up
    harness.go:573: removing temp folder: ""
--- PASS: kuttl (298.95s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/overrides_druid-latest-28.0.1_zookeeper-latest-3.9.2_hadoop-latest-3.4.0_openshift-false (298.94s)
PASS

--test-suite smoke-latest passes too: druid-operator-it-custom/16