stackabletech / hbase-operator

Kubernetes Operator for Apache HBase built by Stackable for the Stackable Data Platform
https://stackable.tech
Other
16 stars 4 forks source link

fix: env-overrides with tests #550

Closed adwk67 closed 2 months ago

adwk67 commented 2 months ago

Description

fix: implemented env-var merge and added tests

Tests: AKS: :green_circle: OKD: :green_circle: (except Omid test, but a separate issue has been opened for that)

Definition of Done Checklist

# Author
- [x] Changes are OpenShift compatible
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [x] Code contains useful comments
- [x] Code contains useful logging statements
- [x] (Integration-)Test cases added
- [x] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated
razvan commented 2 months ago

why is the "definition of done" duplicated ? :)