stackabletech / hdfs-operator

Apache Hadoop HDFS operator for Stackable
Other
40 stars 4 forks source link

chore: bump operator-rs to 0.62.0 #454

Closed NickLarsenNZ closed 9 months ago

NickLarsenNZ commented 10 months ago

Description

Definition of Done Checklist

# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
sbernauer commented 9 months ago

Sorry for bringing the bad news but there are some merge conflicts with https://github.com/stackabletech/hdfs-operator/pull/457

NickLarsenNZ commented 9 months ago

Sorry for bringing the bad news but there are some merge conflicts with #457

Story of my day @sbernauer... will fix and request approval

siegfriedweber commented 9 months ago

Please use ListenerOperatorVolumeSourceBuilder::build_pvc in container::ContainerConfig::volume_claim_templates when #450 is merged.

nightkr commented 9 months ago

Oops, missed this and ended up doing it in parallel.. dunno if there's anything relevant to grab from it but https://gist.github.com/nightkr/da4eb77f001dfb59a85bc43cbff39634

NickLarsenNZ commented 9 months ago

Oops, missed this and ended up doing it in parallel.. dunno if there's anything relevant to grab from it but https://gist.github.com/nightkr/da4eb77f001dfb59a85bc43cbff39634

@nightkr maybe in a new PR? I'd like to get this in now so others can build off of it as the merge conflicts are getting tricky to resolve.

NickLarsenNZ commented 9 months ago

Merging, even though kuttl tests aren't working yet. We will fix forward.