search

stackabletech / issues

This repository is only for issues that concern multiple repositories or don't fit into any specific repository
2 stars 0 forks source link

Don't stop reconciling if one of the objects is not deserializable #211

Closed nightkr closed 1 week ago

nightkr commented 2 years ago

Currently our watchers break entirely if any object fails to deserialize. Ideally this should be confined to only affect the object in question.

The prerequisites have been done by fixing kube-rs and bringing the necessary changes into operator-rs. A sample implementation has also been done for NiFi, we now need to roll this out across the board.

nightkr commented 3 months ago

Will discuss with upstream kube-rs (and maybe k8s-openapi?) on where to go from here.

nightkr commented 2 months ago

https://github.com/kube-rs/kube/pull/1556 is merged, we should be able to trial-migrate an operator to DeserializeGuard<K>. A merge and full rollout should wait until there is a new release of kube-rs with it.

nightkr commented 2 months ago

Trial PR: https://github.com/stackabletech/nifi-operator/pull/662

sbernauer commented 1 month ago

https://github.com/kube-rs/kube/releases/tag/0.94.0 released

nightkr commented 1 month ago

The Nifi-Operator PR has now been updated to use the release builds.

nightkr commented 3 weeks ago

Nifi-Operator PR is merged, ready for wider rollout.

nightkr commented 1 week ago

Aaand that should be all of them, nice!

lfrancke commented 1 week ago

Great work! Thank you!