Closed razvan closed 3 months ago
Can you please include a snippet that we can use for the release notes later?
e.g. (the table is hard to read)
Here is a snippet that demonstrates how environment and configuration overrides work for Apache Zookeeper:
spec:
servers:
envOverrides:
COMMON_VAR: role-value # overridden by role group below
ROLE_VAR: role-value # only defined here at role level
configOverrides:
zoo.cfg:
prop.common: role
prop.role: role
roleGroups:
primary:
replicas: 2
config:
myidOffset: 10
envOverrides:
COMMON_VAR: group-value # overrides role value
GROUP_VAR: group-value # only defined here at group level
configOverrides:
zoo.cfg:
prop.common: group
prop.group: group
This example is fictional because the properties written to the zoo.cfg
file are not used by Zookeeper in any way.
What ends up being written in the Pod's environment are the variables:
COMMON_VAR=group-value
ROLE_VAR=role-value
GROUP_VAR=group-value
Similarly, the zoo.cfg
file of the primary
group will contain:
prop.common=group
prop.role=role
prop.group=group
Of course, these are not the only settings that the operator will configure.
Thank you, that is useful but not really all that usually goes into the release notes. We'd need a sentence on what has been changed/fixed and this could then go in there in addition to that.
This fine ?
- Added tests for config and environment overrides in all operators.
- Fixed config and overrides in operators where it wasn't working as expected (ex. Trino, Spark, etc).
The tests are not really release notes material. If I were to read release notes I'd be interested in knowing which operators were actually fixed. It's a bit hard to see from the list above, can you give me the list of operators that had bugs before but are fixed in 24.11?
It's a bit hard to see from the list above, can you give me the list of operators that had bugs before but are fixed in 24.11?
Yes, it's not easy for me either. Luckily we used conventional commit messages so I'm pretty sure it was:
Issue checklist
Verify (and fix if necessary) that property overrides (env, conf) work as intended in all operators.
There have been reports that this is not the case. Examples:
This issue tracks the state of this feature across all operators:
Release Notes
Trino, Spark, HBase, Airflow: These used to have https://github.com/stackabletech/issues/issues/548[issues] where config and environment variable overrides would not always work as expected, this has now been fixed