stackabletech / issues

This repository is only for issues that concern multiple repositories or don't fit into any specific repository
2 stars 0 forks source link

Release OLM manifests 24.4.0-1 [was: 24.3.0-1] #576

Closed razvan closed 6 months ago

razvan commented 7 months ago

Description

Note on the version: initially this release was meant to be named 24.3.0-1 but according to semver rules, this is a pre-release to 24.3.0 and the operator certification pipeline rejects it. Therefore the decision was made to rename it to 24.4.0-1.

It was discovered that the secret op is missing the permission to update secrets. This ClusterRole permission was added after 23.11.0 and due to a mistake in the OLM generation process, it was lost in24.3.0.

This is a bug that prevents users of 23.11.0 to upgrade to 24.3.0

Solution

Issue a bugfix "release" for the OLM packages and not a full SDP platform release.

This OLM release will be named 24.3.0-1 24.4.0-1 and will only exist in the certified operators repository.

This release will:

This release will not:

Testing workflow

Checkout 24.3.0 tag in operator repo:

cd ~/repo/stackable/airflow-operator
git checkout 24.3.0

Create new branch (from main) in certified ops repo:

cd ~/repo/stackable/openshift-certified-operators/operators
git switch -c stackable-airflow-operator-24.4.0-1

Generate 24.4.0-1 OLM manifests

cd ~/repo/stackable/stackable-utils
./olm/build-manifests.py --openshift-versions 'v4.11-v4.15' --release 24.4.0-1 --repo-operator ~/repo/stackable/airflow-operator --replaces 23.11.0 --skips 24.3.0 --quay-release 24.3.0           

Generate OLM bundles:

cd ~/repo/stackable/stackable-utils
./olm/build-bundles.sh -r 23.11.0 -o airflow -c ~/repo/stackable/openshift-certified-operators
./olm/build-bundles.sh -r 24.3.0 -o airflow -c ~/repo/stackable/openshift-certified-operators
./olm/build-bundles.sh -r 24.4.0-1 -o airflow -c ~/repo/stackable/openshift-certified-operators

Generate or update the custom catalog:

cd ~/repo/stackable/stackable-utils
./olm/multi-op-catalog.sh airflow
# This step is only needed once
# the catalog is then pulled automatically by OLM with new updates
kubectl create -f catalog-source.yaml -n stackable-operators

Use the OperatorHub UI to install the operator.

Run the smoke test:

cd ~/repo/stackable/airflow-operator
./scripts/run-tests --skip-release --test-suite openshift --test smoke

Done!

### Manifests and upgrade tests
- [x] https://github.com/stackabletech/openshift-certified-operators/tree/stackable-commons-operator-24.4.0-1
- [x] https://github.com/stackabletech/openshift-certified-operators/tree/stackable-secret-operator-24.4.0-1
- [x] https://github.com/stackabletech/openshift-certified-operators/tree/stackable-listener-operator-24.4.0-1
- [x] https://github.com/stackabletech/openshift-certified-operators/tree/stackable-zookeeper-operator-24.4.0-1
- [x] https://github.com/stackabletech/openshift-certified-operators/tree/stackable-hdfs-operator-24.4.0-1
- [x] https://github.com/stackabletech/openshift-certified-operators/tree/stackable-hive-operator-24.4.0-1
- [x] https://github.com/stackabletech/openshift-certified-operators/tree/stackable-hbase-operator-24.4.0-1
- [x] https://github.com/stackabletech/openshift-certified-operators/tree/stackable-opa-operator-24.4.0-1
- [x] https://github.com/stackabletech/openshift-certified-operators/tree/stackable-kafka-operator-24.4.0-1
- [x] https://github.com/stackabletech/openshift-certified-operators/tree/stackable-nifi-operator-24.4.0-1
- [x] https://github.com/stackabletech/openshift-certified-operators/tree/stackable-druid-operator-24.4.0-1
- [x] https://github.com/stackabletech/openshift-certified-operators/tree/stackable-spark-operator-24.4.0-1
- [x] https://github.com/stackabletech/openshift-certified-operators/tree/stackable-trino-operator-24.4.0-1
- [x] https://github.com/stackabletech/openshift-certified-operators/tree/stackable-airflow-operator-24.4.0-1
- [x] https://github.com/stackabletech/openshift-certified-operators/tree/stackable-superset-operator-24.4.0-1
### Certification
- [ ] https://github.com/redhat-openshift-ecosystem/certified-operators/pull/3801
- [ ] https://github.com/redhat-openshift-ecosystem/certified-operators/pull/3802
- [ ] https://github.com/redhat-openshift-ecosystem/certified-operators/pull/3803
- [ ] https://github.com/redhat-openshift-ecosystem/certified-operators/pull/3804
- [ ] https://github.com/redhat-openshift-ecosystem/certified-operators/pull/3805
- [ ] https://github.com/redhat-openshift-ecosystem/certified-operators/pull/3816
- [ ] https://github.com/redhat-openshift-ecosystem/certified-operators/pull/3818
- [ ] https://github.com/redhat-openshift-ecosystem/certified-operators/pull/3821
- [ ] https://github.com/redhat-openshift-ecosystem/certified-operators/pull/3824
- [ ] https://github.com/redhat-openshift-ecosystem/certified-operators/pull/3823
- [ ] https://github.com/redhat-openshift-ecosystem/certified-operators/pull/3819
- [ ] https://github.com/redhat-openshift-ecosystem/certified-operators/pull/3822
- [ ] https://github.com/redhat-openshift-ecosystem/certified-operators/pull/3817
- [ ] https://github.com/redhat-openshift-ecosystem/certified-operators/pull/3814
- [ ] https://github.com/redhat-openshift-ecosystem/certified-operators/pull/3815
nightkr commented 7 months ago

@razvan was https://github.com/stackabletech/issues/issues/498 solved in the previous release? That's a pretty breaking change and not something I'd be comfortable applying to a patch release.

razvan commented 7 months ago

@razvan was #498 solved in the previous release? That's a pretty breaking change and not something I'd be comfortable applying to a patch release.

it's ... complicated. This was correct (from the perspective of existing users) in 23.4.0, then broken in 23.11.0 and 24.3.0.

So I consider it a bug fix.

lfrancke commented 7 months ago

Should we announce this known bug on etc..discord and GitHub and what is the approximate timeline?

lfrancke commented 6 months ago

This is in done but there are a whole bunch of checklist items unchecked and it's not closed. Can you update the ticket?