search

stackabletech / issues

This repository is only for issues that concern multiple repositories or don't fit into any specific repository
2 stars 0 forks source link

Unfork h2 crate #636

Closed nightkr closed 2 months ago

nightkr commented 2 months ago

Description

Currently, secret-operator and listener-operator use a forked version of the h2 crate due to https://github.com/hyperium/tonic/issues/243.

Kubernetes v1.26 has fixed the invalid data from Kubernetes' side, such that we no longer need to relax this check once drop support for older versions.

Value

The forked crate becomes a special case that makes it harder to stay up to date with upstream.

Dependencies

Tasks

(Information Security) Risk Assessment

This should help us stay up to date with upstream h2.

Accessibility Assessment

N/A

Quality

The test suite should pass, with an emphasis on our current minimum supported versions.

## Release Notes N/A, internal change - [ ] https://github.com/stackabletech/secret-operator/pull/495 - [ ] https://github.com/stackabletech/listener-operator/pull/219
sbernauer commented 2 months ago

I need to check if other operators than secret and listener are using h2 (probably not)

nightkr commented 2 months ago

A lot of them will be pulling in h2, but they shouldn't have needed the patch to begin with.

sbernauer commented 2 months ago

Searched for [patch.crates-io] in our github org, could not find any other h2 patches. Closing this

lfrancke commented 2 months ago

Could you please add a comment here with a snippet that could go into the release notes? It should mention that this means 1.25 doesn't work anymore.

sbernauer commented 2 months ago

Sticking to our usual release notes:

This release supports the following Kubernetes versions:

These Kubernetes versions are no longer supported:

lfrancke commented 2 months ago

Okay, come release note time I'd include a sentence like this with an asterisk next to the versions we remove (OpenShift and Kubernetes):

"A change was merged (link to https://github.com/stackabletech/issues/issues/636) that breaks compatiblity with Kubernetes 1.25 and older. This includes OpenShift x.yz"

sbernauer commented 2 months ago

Ok, maybe something like

These Kubernetes versions are no longer supported: