stackabletech / nifi-operator

A kubernetes operator for Apache NiFi
Other
28 stars 3 forks source link

CI clippy didn't emit warning about too large types that were found when running clippy locally #617

Open soenkeliebau opened 3 months ago

soenkeliebau commented 3 months ago

When reviewing #614 I ran clippy locally and got the warnings pasted below, but CI running clippy did not alert on these https://github.com/stackabletech/nifi-operator/actions/runs/9003755958

Probably worth investigating why this differs at some point.

My local rust:

❯ cargo --version
cargo 1.77.2 (e52e36006 2024-03-26)

Version stated in ci: RUST_TOOLCHAIN_VERSION: "1.77.2"

Warnings:

warning: the `Err`-variant returned from this function is very large
   --> rust/operator-binary/src/controller.rs:638:6
    |
186 |       ProductConfigLoadFailed { source: config::Error },
    |       ------------------------------------------------- the largest variant contains at least 128 bytes
...
210 |       BoostrapConfig { source: crate::config::Error },
    |       ----------------------------------------------- the variant `BoostrapConfig` contains at least 128 bytes
...
213 | /     BuildProductConfig {
214 | |         source: crate::config::Error,
215 | |         rolegroup: RoleGroupRef<NifiCluster>,
216 | |     },
    | |_____- the variant `BuildProductConfig` contains at least 128 bytes
...
638 |   ) -> Result<Service> {
    |        ^^^^^^^^^^^^^^^
    |
    = help: try reducing the size of `controller::Error`, for example by boxing large elements or replacing it with `Box<controller::Error>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
    = note: `#[warn(clippy::result_large_err)]` on by default

warning: the `Err`-variant returned from this function is very large
   --> rust/operator-binary/src/controller.rs:792:6
    |
186 |       ProductConfigLoadFailed { source: config::Error },
    |       ------------------------------------------------- the largest variant contains at least 128 bytes
...
210 |       BoostrapConfig { source: crate::config::Error },
    |       ----------------------------------------------- the variant `BoostrapConfig` contains at least 128 bytes
...
213 | /     BuildProductConfig {
214 | |         source: crate::config::Error,
215 | |         rolegroup: RoleGroupRef<NifiCluster>,
216 | |     },
    | |_____- the variant `BuildProductConfig` contains at least 128 bytes
...
792 |   ) -> Result<Service> {
    |        ^^^^^^^^^^^^^^^
    |
    = help: try reducing the size of `controller::Error`, for example by boxing large elements or replacing it with `Box<controller::Error>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

warning: the `Err`-variant returned from this function is very large
    --> rust/operator-binary/src/controller.rs:1323:50
     |
186  |       ProductConfigLoadFailed { source: config::Error },
     |       ------------------------------------------------- the largest variant contains at least 128 bytes
...
210  |       BoostrapConfig { source: crate::config::Error },
     |       ----------------------------------------------- the variant `BoostrapConfig` contains at least 128 bytes
...
213  | /     BuildProductConfig {
214  | |         source: crate::config::Error,
215  | |         rolegroup: RoleGroupRef<NifiCluster>,
216  | |     },
     | |_____- the variant `BuildProductConfig` contains at least 128 bytes
...
1323 |   fn external_node_port(nifi_service: &Service) -> Result<i32> {
     |                                                    ^^^^^^^^^^^
     |
     = help: try reducing the size of `controller::Error`, for example by boxing large elements or replacing it with `Box<controller::Error>`
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

warning: `stackable-nifi-operator` (bin "stackable-nifi-operator") generated 3 warnings