search

stackabletech / operator-rs

A simple wrapper/framework around kube-rs to make implementing Operators/Controllers easier
Apache License 2.0
116 stars 12 forks source link

chore: Adjust changelog to include changes from #730 #739

Closed Techassi closed 6 months ago

Techassi commented 6 months ago

This is a follow-up PR to add an entry to the changelog for changes introduced in #730. The previous PR accidentally didn't include this entry.

Techassi commented 6 months ago

Easily missed.

Is there a way in Github Actions to warn but not block? Would be nice to have a check for changelog edits in PRs but not enforce it.

We could use conventional commits for auto-generation of the change log. But that would require some more tooling and research. Happy to explore this further, as I already suggested it a few months back.

NickLarsenNZ commented 6 months ago

We could use conventional commits for auto-generation of the change log. But that would require some more tooling and research. Happy to explore this further, as I already suggested it a few months back.

I'm keen to automate this, but wonder how much friction is could generate? I'm a fan of conventional commits (for this reason, but also search-ability) but others might find it a bit of a showstopper to their flow. Especially due to the whole squash thing where commit messages are quite free-style.

I know you said you'd explore it further, but my question is: would it be a pre-commit/pre-push hook run locally? Or something that runs in Github Actions which then pushes a commit?

Either way, I'm pro-exploration.