stackabletech / operator-rs

A simple wrapper/framework around kube-rs to make implementing Operators/Controllers easier
Apache License 2.0
116 stars 12 forks source link

refactor!: Default TlsClientDetails to webPki #742

Closed sbernauer closed 4 months ago

sbernauer commented 6 months ago

Description

DO NOT MERGE, demonstration purpose only. Also missing a Changelog entry, which warns all operators - which in turn need a BREAKING changelog entry as this is a gigabreaking change for them.

Diff e.g. in opa-operator:

--- a/deploy/helm/opa-operator/crds/crds.yaml
+++ b/deploy/helm/opa-operator/crds/crds.yaml
@@ -107,6 +107,11 @@ spec:
                                   description: Root HTTP path of the identity provider. Defaults to `/`.
                                   type: string
                                 tls:
+                                  default:
+                                    verification:
+                                      server:
+                                        caCert:
+                                          webPki: {}
                                   description: Use a TLS connection. If not specified no TLS will be used.
                                   nullable: true
                                   properties:

Definition of Done Checklist

# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
fhennig commented 6 months ago

gigabreaking

lol :laughing:

sbernauer commented 6 months ago

lol 😆

@Techassi would be proud of me!

Techassi commented 6 months ago

I am! 😜

sbernauer commented 4 months ago

Will implement this at some point of time, but this requires an upfront announcement